From: Sebastian Keller Date: Sat, 18 Jan 2014 13:38:41 +0000 (+0100) Subject: AppDisplay: fix isTerminal() check for apps without .desktop files X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~2907 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=4ed0f3e5f0f9d2f7d214026c01835eeb818cbc13;p=gnome-shell.git AppDisplay: fix isTerminal() check for apps without .desktop files If the app has no .desktop file get_app_info() returns null. This breaks window switching using the dash for those apps. https://bugzilla.gnome.org/show_bug.cgi?id=722494 --- diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index 154ddaa23..19ba949ee 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -47,7 +47,10 @@ const PAGE_SWITCH_TRESHOLD = 0.2; const PAGE_SWITCH_TIME = 0.3; function _isTerminal(app) { - let categories = app.get_app_info().get_categories() || []; + let info = app.get_app_info(); + if (!info) + return false; + let categories = info.get_categories() || []; return categories.indexOf('TerminalEmulator') > -1; }